Eirik A

Results 370 comments of Eirik A

> MPL-2.0 It shouldn't be a problem. Particularly if it's an opt-in feature, as then it's up to users whether they want the stricter license the transitive dependency comes with.

Given we want opt-in for many reasons, i think if we add a feature for it in `kube-client/Cargo.toml`: ```toml webpki-roots = ["hyper-rustls/webpki-roots"] ``` plus re-export it from `kube/Cargo.toml` (i.e. feature...

I think this would be very useful, and a clear upgrade on the original suggestion. Happy to do reviews on sketches. Your plan sounds sensible to me. A few quick...

> not quite sure I see the intended use case. [..] import paths become shorter to type out manually? As it stands, yes. The **main benefit** is an alternative **shorter...

Hey, thanks for this. This sounds like a bug if it's not working. Naming wise this feels slightly odd. The restriction that an owner must be in the same namespace...

Hey, yes, in essence this is what I am proposing! Although it might amount to doing similar things to the linked PR first. The difficulty of your PR would basically...

Hey, that would be a [kube issue](https://github.com/kube-rs/kube/issues). I think this is probably close. But want to have a think w.r.t. more complicated filters, because while they are useful right now,...

Updated this PR against current. Predicates are stabilised in 0.96, but the `for_streams` interface for `Controller` is not, hopefully we can settle this down if we get good confidence in...

Yeah, I think having some type of validation like this would be good. Putting it on straight on `PatchParams::validate` could be sensible, although it is actually run by default inside...

Hey, thanks for this! I think the reasoning makes sense for it to be here. 1. The extension of the ssl feature selection makes sense. It probably needs to be...