clusterpedia icon indicating copy to clipboard operation
clusterpedia copied to clipboard

the exact chart dependecy version

Open calvin0327 opened this issue 2 years ago • 7 comments

Signed-off-by: calvin0327 [email protected]

What type of PR is this? /kind feature

What this PR does / why we need it: the chart version updates are very fast, We have not do any testing on the new version, so we should specify the exact version.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

calvin0327 avatar Aug 14 '22 11:08 calvin0327

Hi @calvin0327, Thanks for your pull request! If the PR is ready, use the /auto-cc command to assign Reviewer to Review. We will review it shortly.

Details

Instructions for interacting with me using comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

github-actions[bot] avatar Aug 14 '22 11:08 github-actions[bot]

/lgtm

Iceber avatar Aug 16 '22 02:08 Iceber

https://github.com/clusterpedia-io/clusterpedia/runs/7849779721?check_suite_focus=true#step:4:1856

dependencies error:

  Error: the lock file (Chart.lock) is out of sync with the dependencies file (Chart.yaml). Please update the dependencies
  Error: INSTALLATION FAILED: An error occurred while checking for chart dependencies. You may need to run `helm dependency build` to fetch missing dependencies: found in Chart.yaml, but missing in charts/ directory: postgresql, mysql, common

Iceber avatar Aug 16 '22 04:08 Iceber

/remove-lgtm

Iceber avatar Aug 16 '22 07:08 Iceber

/hold

calvin0327 avatar Aug 16 '22 09:08 calvin0327

@calvin0327

Command hold is not found
Details

Instructions for interacting with me using comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

github-actions[bot] avatar Aug 16 '22 09:08 github-actions[bot]

I found that the specific version has been set in the Chart.lock, and the actual user uses the fixed version when using kubectl dependency build

The Chart.yaml uses a vague version, and the user can use helm dependency update to update the minor version.

Iceber avatar Aug 16 '22 09:08 Iceber

agree with you, so i will close the pr.

calvin0327 avatar Aug 17 '22 06:08 calvin0327