clusternet icon indicating copy to clipboard operation
clusternet copied to clipboard

support helm install flags

Open wl-chen opened this issue 2 years ago • 8 comments

What would you like to be added:

I hope that clusternet supports helm install flags options when installing chart.

Why is this needed:

helm chart install timeout time is default 5 mintues. If this time is exceeded, it will return failure. But my localization's installazition needs more 5 minutes sometimes. And now clusternet dont support helm install flags. So i cant use --timeout or --wait flags to Increase waiting time.

wl-chen avatar Jul 04 '22 12:07 wl-chen

But my localization's installazition needs more 5 minutes sometimes. And now clusternet dont support helm install flags. So i cant use --timeout or --wait flags to Increase waiting time.

@wl-chen I think we can add a new field in HelmChart CRD object, where a default timeout value can be set. And we can override this default value in Localization when needed.

Would you like to implement this feature?

dixudx avatar Jul 04 '22 13:07 dixudx

But my localization's installazition needs more 5 minutes sometimes. And now clusternet dont support helm install flags. So i cant use --timeout or --wait flags to Increase waiting time.

@wl-chen I think we can add a new field in HelmChart CRD object, where a default timeout value can be set. And we can override this default value in Localization when needed.

Would you like to implement this feature?

@dixudx In addition to the timeout value, can you add a --wait value? wecom-temp-bdb917ad7e08c59f9ecfc80ea11c79e4

wl-chen avatar Jul 05 '22 02:07 wl-chen

In addition to the timeout value, can you add a --wait value?

--wait and --timeout are usually used together. I'm fine to add these two new fields.

@wl-chen Please feel free to implement this if you're interested.

dixudx avatar Jul 05 '22 02:07 dixudx

In addition to the timeout value, can you add a --wait value?

--wait and --timeout are usually used together. I'm fine to add these two new fields.

@wl-chen Please feel free to implement this if you're interested.

ok, i will try it~

wl-chen avatar Jul 05 '22 09:07 wl-chen

@wl-chen Any progress on this new feature?

dixudx avatar Jul 21 '22 07:07 dixudx

@wl-chen Any progress on this new feature?

I've been busy lately, this week or next week.

wl-chen avatar Jul 21 '22 07:07 wl-chen

@wl-chen Any progress on this new feature?

I want to add an annotation (helm chart timeout value) on helmchart resources. And chart when installing release can read this annotation. What do you think of it?

wl-chen avatar Jul 22 '22 11:07 wl-chen

I want to add an annotation (helm chart timeout value) on helmchart resources. And chart when installing release can read this annotation. What do you think of it?

I think we can add it to HelmChartSpec, and set a default timeout value.

dixudx avatar Jul 23 '22 02:07 dixudx