ruby-build-action icon indicating copy to clipboard operation
ruby-build-action copied to clipboard

Is steps.ruby.outputs.ruby-path necessary?

Open eregon opened this issue 5 years ago • 1 comments

The README shows:

    - name: Print version
      run: ${{ steps.ruby.outputs.ruby-path }} --version

Is there a reason to use ${{ steps.ruby.outputs.ruby-path }} --version instead of just ruby --version?

It seems the installed Ruby's bin directory is added to PATH: https://github.com/clupprich/ruby-build-action/blob/d2971553edbe27a9cb7e277f22b549114bfd3ccf/src/index.js#L46 And that should be enough, just like setup-ruby and every other CI. So I would suggest to simplify in the README, and not need an output variable as that's quite verbose.

eregon avatar Nov 24 '19 11:11 eregon