docker-adminer icon indicating copy to clipboard operation
docker-adminer copied to clipboard

Published 20 hours ago • verified publisher icon clue

Base on official PHP 7.0 Alpine image

Open kusmierz opened this issue 8 years ago • 12 comments

see #16 and #20

kusmierz avatar Apr 10 '16 21:04 kusmierz

seems good to me! :+1:

mathroc avatar Apr 11 '16 07:04 mathroc

I just thinking about difference between:

ADD http://www.adminer.org/static/download/$ADMINER_VERSION/adminer-$ADMINER_VERSION.php /var/www/index.php

and downloading it using wget (system one or from apk, but system's is without https support).

Mainly first one will download each and every time on build, and wget will probably use cached version. @mathroc what do you think?

kusmierz avatar Apr 11 '16 07:04 kusmierz

@kusmierz if ADD works I'm fine with it. (dont' mind either way)

mathroc avatar Apr 11 '16 07:04 mathroc

@clue about your [comment on versionning](https://github.com/clue/docker-adminer/pull/19#discussion_r59180165], with the docker hub we can provide both the latest and tagged release. in other images I'm doing it this way:

  • master branch have SOMETHING_VERSION=latest and configured on docker hub to auto build as tag latest
  • releases branch with fixed version and tags Vx.x.x and tags are set to build automatically on docker hub too

anyway, this can be done in a second time, @kusmierz what do you think about sticking with latest for the time being and working on tags later ?

mathroc avatar Apr 11 '16 11:04 mathroc

:+1:

kusmierz avatar Apr 11 '16 12:04 kusmierz

@mathroc any chances to push this version into the wild?

kusmierz avatar Apr 18 '16 11:04 kusmierz

I don't have more comment for this PR. it's ready as far as I'm concerned. it's up to @clue to either merge this into master or in another branch (to tag it alpine un docker hub until it's a bit more tested)

mathroc avatar Apr 18 '16 11:04 mathroc

@mathroc @kusmierz I think it's not helpful for @clue to have 3 open PRs here now. Could you maybe close the irrelevant ones? Would be great to finally see some progress here.

mikehaertl avatar May 04 '16 07:05 mikehaertl

@clue do you think it can be merged once rebased (/ping @kusmierz ) ? or do you have other suggestions ?

mathroc avatar Jun 07 '16 15:06 mathroc

@clue do you think it can be merged once rebased

Afaict there are still some outstanding, uncommented issues in this PR, other than that I'm good with this change :+1:

clue avatar Jun 07 '16 23:06 clue

@kusmierz I've made a few more comments, do you mind taking a look and rebasing the PR ?

@clue is there still issues you'd like to be taken care for this PR? moving to php -S in another PR before this one maybe ?

mathroc avatar Sep 03 '16 20:09 mathroc

@clue do we really need ODBC (#15)? It makes only problems (749192d)...

kusmierz avatar Sep 05 '16 09:09 kusmierz