mpc-hc icon indicating copy to clipboard operation
mpc-hc copied to clipboard

Normalize resets when skipping back

Open JNavas2 opened this issue 10 months ago • 3 comments

With Normalize enabled with Max Amplification 400% and Regain Volume not enabled, if I Skip Back (e.g., because I missed something), Normalize resets to Max, which can be unpleasant. While I think it makes sense to reset when loading a different file, I don't think it should reset when skipping in the same file. (I'd prefer not to lower Max Amplification because I have some files that need a higher value.)

Thank you for MPC-HC!

MPC-HC 2.2.0 OS Name Microsoft Windows 10 Pro Version 10.0.19045 Build 19045

mpc-hc64_g67cIDHduQ

JNavas2 avatar Apr 06 '24 02:04 JNavas2

Regain has NOTHING to do with this. It simply resets the algorithm on seek.

I need a good sample file to analyze problem. And timestamps to seek from and to.

clsid2 avatar Apr 09 '24 12:04 clsid2

Thank you. I understand that Regain has nothing to do with my issue. I confirmed the setting for your information. To make it as easy for you as possible I'll create a synthetic video file that reproduces the problem. That might take me a couple of days due to my current heavy schedule. When I have it, I'll update this Issue.

JNavas2 avatar Apr 10 '24 02:04 JNavas2

Thank you. I understand that Regain has nothing to do with my issue. I confirmed the setting for your information. To make it as easy for you as possible I'll create a synthetic video file that reproduces the problem. That might take me a couple of days due to my current heavy schedule. When I have it, I'll update this Issue.

@JNavas2 any news regarding the sample file?

NBruderman avatar May 27 '24 12:05 NBruderman

Thanks for the reminder. Attached is a public domain audio file that demonstrates the problem here. I'm listening with Sony WF-1000XM4 earbuds over Bluetooth. When I start playing with the audio quite loud, the volume gets automatically reduced as I play it. Then if I jump back with the left arrow or to near the beginning from near the end, the audio is suddenly as loud again as when I started playing. gettysburg_johng_librivox.zip

mpc-hc64_WpmYSlDYQM

JNavas2 avatar May 29 '24 00:05 JNavas2

Try 2.2.1.48

clsid2 avatar May 29 '24 17:05 clsid2

Unfortunately, the problem is not fixed. I was watching a long video in 2.2.1.48, and jumped back to review something, and the audio was much louder.

JNavas2 avatar Jun 01 '24 02:06 JNavas2

I am unable to reproduce the problem with the given sample. Give timestamp from where you seek and where to.

clsid2 avatar Jun 01 '24 11:06 clsid2

Unfortunately, the problem is not fixed. I was watching a long video in 2.2.1.48, and jumped back to review something, and the audio was much louder.

How did you jump back? With the arrow keys, or with the mouse? Because in the original issue it refers to the arrow keys, the behavior might be different with a large skip with the mouse on the timeline

NBruderman avatar Jun 01 '24 11:06 NBruderman

That does not matter. A seek is a seek.

clsid2 avatar Jun 01 '24 12:06 clsid2

@NBruderman

How did you jump back? With the arrow keys, or with the mouse?

I usually jump back with the left arrow key, but I also see the issue when I jump back with a mouse.

@clsid2

I am unable to reproduce the problem with the given sample. Give timestamp from where you seek and where to.

Last night when I was about halfway through watching an episode of Beacon 23 (TV series) in MPC-HC 2.2.1.48 (on Windows 10) using Sony WF-1000XM4 Bluetooth earphones, I pressed the left arrow key to jump back and replay something interesting, and the volume jumped up roughly 6 dB. As I continued listening, the volume went back down to what it had been before I jumped back.

How about giving me a build that logs any changes to audio gain? That might nail down the issue.

JNavas2 avatar Jun 02 '24 15:06 JNavas2

I reproduced the problem as described in my last Comment, this time recording the audio output with Audacity, which is attached to this Comment. Halfway through the clip (which is trimmed from the end of a much longer recording) I used the left arrow to jump back for replay. Note how much louder the replay is compared to the first time through. sample.zip

JNavas2 avatar Jun 02 '24 16:06 JNavas2

p.s. Here is an audio only file that reproduces the problem for me, matching the sample in my last Comment when I press the left arrow to jump back. UPDATE: Play from the beginning with my audio settings, press left arrow at about 2:15. (The time scale is not correct.) Beacon 23 S02E05.zip

JNavas2 avatar Jun 02 '24 18:06 JNavas2

ADDITIONAL INFO: I do not see this audio gain problem when playing through the laptop speakers, just when playing through my Sony WF-1000XM4 Bluetooth earphones.

JNavas2 avatar Jun 03 '24 00:06 JNavas2

Is there anything more I could do to help on this?

JNavas2 avatar Jun 07 '24 16:06 JNavas2

It should be fixed in latest build, and if not you are out of luck, because I am not going to make any further changes.

clsid2 avatar Jun 07 '24 16:06 clsid2

It should be fixed in latest build, and if not you are out of luck, because I am not going to make any further changes.

I assume you're referring to development build 2.2.1.72, but I didn't see download links.

JNavas2 avatar Jun 07 '24 21:06 JNavas2

click on "assets" to expand download links

clsid2 avatar Jun 07 '24 21:06 clsid2

Thanks. On my sample, 2.2.1.72 till jumps up, but only about 7dB. On a previous version it had jumped up about 14dB. So, not perfect, but major improvement. Thank you.

JNavas2 avatar Jun 08 '24 00:06 JNavas2

UPDATE: I've now played some real videos, and was not able to reproduce the problem, so I hereby pronounce it FIXED in 2.2.1.72. Thank you! 👍 👏

JNavas2 avatar Jun 08 '24 14:06 JNavas2