Bugs on some dialog boxes

[tsubasanouta]

MPC-HC (64-bit) Build information: Version: 2.1.4 (c82061aef) Compiler: MSVC v19.29.30152 Build date: Jan 15 2024 Operating system: Name: Windows 11 (Build 22H2) Version: 10.0.22621 (64-bit)

[adipose]

What resolution. What scaling factor. What font scaling factor.

For me they are fitting.

[xLn2]

I think I've seen similar to this problem before. On Windows installment with Asian languages, I guess the spacing of the latin letters was causing some display problems. But one of the message boxes ignores this.

Or if we look at the sample screenshoots, the window(text area) does not scale according to dpi but text does.

[tsubasanouta]

These strings and Y/N buttons are in English on the dark theme. These strings are in English on the light theme. Only Y/N buttons are in Japanese of Reset settings dialog on the light theme. MPC-BE looks good and Y/N buttons are in Japanese Does these comment give you a clue to the solution?

[adipose]

These strings and Y/N buttons are in English on the dark theme.

These strings are in English on the light theme.

Only Y/N buttons are in Japanese of Reset settings dialog on the light theme.

MPC-BE looks good and Y/N buttons are in Japanese

Does these comment give you a clue to the solution?

Did you see my questions?

[clsid2]

I can reproduce the problem with the Reset Settings dialog in Light Theme. If uses English button text while Dark theme uses translated text.

The text not fitting is likely due to Windows bug with Asian fonts.

[adipose]

I can reproduce the problem with the Reset Settings dialog in Light Theme. If uses English button text while Dark theme uses translated text.

I tried to reproduce this in light theme, but it shows the translations:

[xLn2]

I tried to reproduce this in light theme, but it shows the translations:

Maybe misunderstanding about buttons translation strings. Maybe related this one https://github.com/clsid2/mpc-hc/issues/796#issuecomment-750401186

[adipose]

At 200% DPI on Windows 11, I produced a very strange one:

[xLn2]

First MPC-HC installation language may effect various places, I just randomly tried something for buttons translation. Wide scope investigation will be better.

[adipose]

It is a bit difficult to reproduce this problem. After rebooting, the dialog box sizes correctly. But if I change the display scaling settings around a bit, it breaks it (sometimes). After changing back to 100%, it now does this:

Note, mpc-hc is CLOSED when I make these changes, but it still confuses it, which suggests that Windows itself isn't fully updating its behavior after a display scale change.

[adipose]

https://github.com/clsid2/mpc-hc/pull/2835

This fixes:

1. DPI issues, especially when changing DPI after first run of mpc-hc
2. Dialog calculations are done based on the default message font instead of "current font," which makes text more likely to fit

I don't know for sure if it will fix the above issues, but it definitely is working better than before in my other tests.

[adipose]

Here's a test build, please test out the message box issues.

https://mega.nz/file/wJ4xzAZS#cCxFzCgeIE1u3DVyHv9pGtbYcazI1N-iAxiLe9Rfv2k

[adipose]

@tsubasanouta last call, I think this is fixed.

@clsid2, maybe we can close if no further activity.

[tsubasanouta]

This is fixed. Thank you so much for your work.