mpc-hc icon indicating copy to clipboard operation
mpc-hc copied to clipboard

Published 20 hours ago • verified publisher icon clsid2

Thumbnails appear pixelated

Open libellula opened this issue 1 year ago • 4 comments

Hi Clsid2, first of all, thanks for continuing the development of this great player. I just wanted to report something I noticed which seems odd since MPC-BE, with the same setting, does it well. I posted two thumbnails of the same file, with the same settings, one made by MPC-HC, the other made by MPC-BE. I chose a sample video which exposes the issue very well. My OS is Windows 10 Pro x64, the video renderer is MadVR, but even wth other renderers the issue stays there. fish_-_62123 (Original) mp4_thumbs fish_-62123 (Original) mp4_thumbs 2023 12 09_12 16 44

libellula avatar Dec 09 '23 15:12 libellula

Give a link to that video file.

clsid2 avatar Dec 09 '23 16:12 clsid2

It happens to every video, this one just exposes it more. BTW,

https://github.com/clsid2/mpc-hc/assets/61087558/1948955e-63bc-43db-b150-7b4698cd4358

ghost avatar Dec 09 '23 16:12 ghost

Seems to be due to scaling filter used: https://github.com/Aleksoid1978/MPC-BE/blob/f9f8d22f89ed27cf3eb22d78c37885237c60f573/src/apps/mplayerc/ThumbsTaskDlg.cpp#L218

clsid2 avatar Dec 09 '23 17:12 clsid2

To get the correct result when the image is greatly reduced, you need to use convolution. Interpolation algorithms will perform poorly for reduction. This is especially noticeable in video frames with sharp edges.

v0lt avatar Dec 15 '23 17:12 v0lt

https://github.com/clsid2/mpc-hc/pull/2802

Similar method as mpc-be, but I used stbir_resize as we already have it in the project.

adipose avatar May 24 '24 04:05 adipose