mpc-hc icon indicating copy to clipboard operation
mpc-hc copied to clipboard

Help translating requested

Open adipose opened this issue 5 years ago • 168 comments

The MPC-HC interface is about 98% translated. Although the application isn't receiving too many new features, when it does it introduces new strings that need translating. If you can help please sign up to translate here:

https://www.transifex.com/mpchc/mpchc/

Click here:

image

Here is a help page on joining and helping out with the translations:

https://docs.transifex.com/getting-started-1/translators

adipose avatar Jan 04 '20 17:01 adipose

Send in request to join for translating dutch

xknat avatar Jan 23 '20 10:01 xknat

Thanks, I approved it.

adipose avatar Jan 23 '20 17:01 adipose

@adipose I've send a request to join for Chinese (China)

NightSharp avatar Mar 26 '20 16:03 NightSharp

@NightSharp you should have been approved now.

adipose avatar Mar 28 '20 01:03 adipose

Thanks a lot

At 2020-03-28 09:21:15, "adipose" [email protected] wrote:

@NightSharp you should have been approved now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

NightSharp avatar Mar 28 '20 01:03 NightSharp

In some of the english source strings this character can be found: & Sometimes it is mid word. What does it mean?

ThePirate42 avatar Apr 06 '20 12:04 ThePirate42

That is used for menu shortcuts. So if a menu contains an entry "&Play" you can activate that entry by pressing P while the menu is open.

When translating you can put the & in front of the same letter if the translated string has the same letter. If it doesn't have the same letter, then just remove the &.

clsid2 avatar Apr 06 '20 14:04 clsid2

@adipose I've send a request to join for Russian

AlexStank avatar May 13 '20 20:05 AlexStank

@AlexStank , you should have been accepted now.

adipose avatar May 16 '20 21:05 adipose

I sent a request to help translating to portuguese of portugal.

moonlightz avatar May 22 '20 19:05 moonlightz

I approved it. There is already pt_BR, so maybe you can start with that and update as needed.

adipose avatar May 22 '20 21:05 adipose

Thankx. Portuguese of Brasil isn't my language of choice. When I'm using programs (like MPC-HC) or when using webpages like wikipedia, I switch to English if there isn't Portuguese of Portugal. Portuguese of Brasil is just a mix of Portuguese and latin-Spanish and then they tried to mimic'ed the english phrases form. Here in Portugal, we are now facing another silly language rectification which I think it is ridiculous and they are removing letters from the word we don't pronounce or they are lowercasing the initials of the months of the year or of the weekdays or the year seasons. I know most part of MPC-HC and translation should be mid-easy.

moonlightz avatar May 23 '20 06:05 moonlightz

The latest release didn't include new transations, is this normal?

ThePirate42 avatar May 25 '20 19:05 ThePirate42

Until I sync and merge, they don't get included. I haven't merged them in a few weeks.

adipose avatar May 25 '20 19:05 adipose

That is used for menu shortcuts. So if a menu contains an entry "&Play" you can activate that entry by pressing P while the menu is open.

When translating you can put the & in front of the same letter if the translated string has the same letter. If it doesn't have the same letter, then just remove the &.

I'm afraid that removing & will cause translated versions of MPC-HC lost the menu shortcut function. The best way is to use a (&) at the end of translated string. For example, &Play will be 播放(&P) after translated to Simplified Chinese.

lychichem avatar May 27 '20 03:05 lychichem

lychichem hit a problem when Chinese and other languages don't use the normal 26 alphabet letters. Putting the shortcut letter between ( and ) with & is a good move. I must say the key shortcuts for menu are hidden since ... XP(?)... maybe Vista and the user needs to have the option enabled to see them or when in a dialog an ALT will make them visible. If the key shortcut can't be used, people which are translating strings, can see whole menu and decide and alternative letter in the string but the menu can't have 2 options with same letter for shortcut key. I myself have such problem where half the strings lost the shortcut key. I am almost finishing translating but translating is just the initial step. Then I will have to make lots and lots of corrections like the shortcut keys and make half of them to use other letters. We are not forced to use the same letter as the English version.

Now... I just would like to have mpc-hc translation online editor to tell me the max width of the string because some strings will be broken when displayed and theses strings will need to be shorten.

moonlightz avatar May 27 '20 07:05 moonlightz

lychichem hit a problem when Chinese and other languages don't use the normal 26 alphabet letters. Putting the shortcut letter between ( and ) with & is a good move. I must say the key shortcuts for menu are hidden since ... XP(?)... maybe Vista and the user needs to have the option enabled to see them or when in a dialog an ALT will make them visible. If the key shortcut can't be used, people which are translating strings, can see whole menu and decide and alternative letter in the string but the menu can't have 2 options with same letter for shortcut key. I myself have such problem where half the strings lost the shortcut key. I am almost finishing translating but translating is just the initial step. Then I will have to make lots and lots of corrections like the shortcut keys and make half of them to use other letters. We are not forced to use the same letter as the English version.

Now... I just would like to have mpc-hc translation online editor to tell me the max width of the string because some strings will be broken when displayed and theses strings will need to be shorten.

Yes, certainly nobody force the translation usse the same shortcut, but for other l10n projects, usually the shortcuts are kept same. So not changing shortcut may be an arrangement.

As for strings max length, I have to tell you sadly that nearly no online platform can tell you. Some even can't tell you where the string will be displayed. I've tried manually calculate how many characters can be included in the display area by dividing item width/height givien in the resource files of the program and characters width/height. It's painful so I don't suggest you to do so like me. Maybe an improved string extractor which can extract the string as well as the position and size of its container will solve the problem (but I'm unable to make one for you).

lychichem avatar May 27 '20 08:05 lychichem

1 way is to manually generate the dll file and check manually which are splitted to the next line and shrink strings as musch as possible. Checkboxes and labels usually split to the next line but if the height is not high enough, the rest of the text is not visible.

moonlightz avatar May 27 '20 10:05 moonlightz

I'm afraid that removing & will cause translated versions of MPC-HC lost the menu shortcut function. The best way is to use a (&) at the end of translated string. For example, &Play will be 播放(&P) after translated to Simplified Chinese.

Please just remove menu shortcuts instead of adding letters behind the translations. Almost nobody uses these shortcuts anyway. They aren't visible by default either as moonlightz already mentioned.

clsid2 avatar May 27 '20 10:05 clsid2

Transifex translations should be up to date as of today, including adding Portugal. Future updates will continue to come in every few weeks when I notice some additions. When adding a new language I have to do a bit more work than just merging it, so be patient.

When it comes to string length, we went through a gui upgrade several months ago to allow much wider strings (particularly Russian) to fit where previously they could bleed outside the area. So most strings should fit fine if you keep the translation reasonable. For menus it should just expand to the string size.

As for shortcuts, I would focus on using ctrl/alt type shortcuts as much as possible. If you can keep the underlined char the same, great, but otherwise just eliminate it. The alternative is to review the entire menu or submenu and make sure all your shortcuts are unique (as possible).

adipose avatar May 29 '20 02:05 adipose

I'm thinking of waiting for you to launch the pt-pt lang with next version of MPC-HC and then see the need of small corrections like proper context and shortening of some strings to fit and menu key shortcuts and that should take 1-2 days. I included & in some menu options and removed where there wasn't a compatible letter as mentioned in a post above. The & can be in some other letter as long as there is no duplicate in that specific menu. Very few people will see these menu keys and use them daily. Either remove all or adapt them to the other letters, I would say.

moonlightz avatar May 31 '20 09:05 moonlightz

I can make a test build.

adipose avatar May 31 '20 12:05 adipose

Sure, if you don't mind.

moonlightz avatar May 31 '20 18:05 moonlightz

@moonlightz , here you go, based on the latest transifex import.

https://mega.nz/file/4YZ1WC4K#Q7Lq5THTFbt6yaBy31aMuvdBps3k_AVtpksvImgDXYo

adipose avatar Jun 02 '20 20:06 adipose

It seems you need to do it again. For some reason, the import got the work around where I was at the middle of the translation.

moonlightz avatar Jun 26 '20 21:06 moonlightz

I just imported the newest translations. Do you want another test build?

Are you saying the latest release didn't have the translations from the test build I made you?

adipose avatar Jun 26 '20 23:06 adipose

Yep and yep.

moonlightz avatar Jun 27 '20 09:06 moonlightz

https://mega.nz/file/JRgHwZbS#yEv077dwo6U2XbCxpQWTxAHQ6KU0h9NKxAlx-ukSC8I

This is built from the latest dev source. It should hopefully have all the updated translations.

adipose avatar Jun 28 '20 19:06 adipose

Problems are still there. No idea what's wrong. It should appear as they are translated in transifex but some strings aren't. The Options dialog tree at left is messed up.

moonlightz avatar Jun 29 '20 13:06 moonlightz

Can you send a screenshot of what it looks like, and what the right string should be?

adipose avatar Jun 29 '20 13:06 adipose