flutter_screen icon indicating copy to clipboard operation
flutter_screen copied to clipboard

Published 20 hours ago • verified publisher icon clovisnicolas

iOS/keepOn did not finish the future

Open ened opened this issue 5 years ago • 5 comments

The iOS side of the plugin was missing a result(nil) call for the keepOn function, which has been fixed. Also included:

  • Update iOS project files to latest versions
  • Include 1024x1024 icon for example

ened avatar May 23 '19 18:05 ened

@ened If you only want to use the wakelock functionality, you could use wakelock, which I created due to lacking support from @clovisnicolas. In wakelock, this problem is fixed.

creativecreatorormaybenot avatar Jul 07 '19 02:07 creativecreatorormaybenot

@clovisnicolas Hi Clovis, I'm having this bug too on iOS, can you please merge this?

0xC0A1 avatar Sep 08 '19 02:09 0xC0A1

@kevinrodriguez-io Is there something about wakelock missing for you?

creativecreatorormaybenot avatar Sep 08 '19 09:09 creativecreatorormaybenot

@creativecreatorormaybenot the main reason I'd like this fixed is that Chewie's video player uses flutter_screen under the hood: https://github.com/brianegan/chewie/blob/master/pubspec.yaml#L16

Otherwise your wakelock library works really well!

recastrodiaz avatar Oct 04 '19 15:10 recastrodiaz

@recastrodiaz Thanks for the information. I will propose a PR to the video player that switches to wakelock because of two reasons:

  • It does not use the brightness control in flutter_screen.

  • flutter_screen is not being maintained.

I will post it here when done.

creativecreatorormaybenot avatar Oct 04 '19 17:10 creativecreatorormaybenot