tower icon indicating copy to clipboard operation
tower copied to clipboard

Remove Jingo requirement

Open davedash opened this issue 12 years ago • 3 comments

I don't think Jingo is entirely required, but things like calling JINJA_CONFIG() make that hard... not sure what the best solution here is.

For a starter making JINJA_CONFIG optionally callable might be nice.

davedash avatar Apr 26 '12 00:04 davedash

Makes sense, generally. What do you mean with "making JINJA_CONFIG optionally callable"? doesn't it already have to be a callable for tower to work? If anything, the syntax where JINJA_CONFIG isn't a callable doesn't currently work. Right?

fwenzel avatar Apr 26 '12 01:04 fwenzel

We could try/catch around it and have sensible defaults

clouserw avatar Apr 26 '12 15:04 clouserw

For example JINGO_CONFIG = dict() is valid for jingo, since jingo checks to see if JINGO_CONFIG is just a setting or a callable, if it's a callable it calls it.

We could use that same logic.

But I think also the idea of using some sensible defaults makes sense. We should see what those coffin folks do.

Meanwhile I'll just adopt this syntax :)

davedash avatar Apr 26 '12 21:04 davedash