kitex icon indicating copy to clipboard operation
kitex copied to clipboard

test: add unit test for pkg/remote/codec

Open mxdblcf opened this issue 3 years ago • 5 comments

What type of PR is this? test

What this PR does / why we need it (en: English/zh: Chinese): en: add unit test for pkg/remote/codec zh: 为 pkg/remote/codec包里的函数添加单测。

Which issue(s) this PR fixes:

mxdblcf avatar Jul 14 '22 00:07 mxdblcf

What type of PR is this?

What this PR does / why we need it (en: English/zh: Chinese):

en: zh:

Which issue(s) this PR fixes:

补充下 pr 描述

SinnerA avatar Jul 20 '22 06:07 SinnerA

Run locally:

  go vet -stdmethods=false $(go list ./...)
  go install mvdan.cc/[email protected]
  test -z "$(gofumpt -l -extra .)" 

GuangmingLuo avatar Jul 20 '22 07:07 GuangmingLuo

本地运行:

  go vet -stdmethods=false $(go list ./...)
  go install mvdan.cc/[email protected]
  test -z "$(gofumpt -l -extra .)" 

already use, but not result

mxdblcf avatar Jul 29 '22 15:07 mxdblcf

本地运行:

  go vet -stdmethods=false $(go list ./...)
  go install mvdan.cc/[email protected]
  test -z "$(gofumpt -l -extra .)" 

已使用,但不是结果

please put action again

mxdblcf avatar Jul 29 '22 15:07 mxdblcf

本地运行:

  go vet -stdmethods=false $(go list ./...)
  go install mvdan.cc/[email protected]
  test -z "$(gofumpt -l -extra .)" 

已使用,但不是结果

please put action again

@mxdblcf 执行下:

gofmt -s -w .
gofumpt -l -extra -w .

SinnerA avatar Aug 09 '22 09:08 SinnerA