kitex icon indicating copy to clipboard operation
kitex copied to clipboard
verified publisher icon cloudwego

fix: typo

Open hakusai22 opened this issue 1 year ago • 2 comments

What type of PR is this?

  • fix: typo

hakusai22 avatar Apr 25 '24 06:04 hakusai22

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 25 '24 06:04 CLAassistant

Please try gofumpt -w client/rpctimeout_test.go to make the CI link test pass

Hello, I haven't made any changes to the ast.go and patcher.go files. Their code styles don't match. I have made some modifications here. Could you please help me pass the tests again.

image image

According to the submission time, the code style submitted by Duan yesterday has already failed the test. https://github.com/cloudwego/kitex/pull/1336 image

hakusai22 avatar Apr 25 '24 12:04 hakusai22

Please try gofumpt -w client/rpctimeout_test.go to make the CI link test pass

@Marina-Sakai hello, Can you help me review it again?

hakusai22 avatar Apr 30 '24 02:04 hakusai22

Thank you for your attention and suggestion to this project. Meaningful PRs are always welcome. Please try use some tools to help to add as much typos fix or other optimizations as possible in one PR. A PR with only one typo fixing is less meaningful.

GuangmingLuo avatar May 13 '24 09:05 GuangmingLuo