hertz icon indicating copy to clipboard operation
hertz copied to clipboard

refactor(binding): rm redundant code and perf

Open xiaost opened this issue 8 months ago • 1 comments

What type of PR is this?

refactor

Check the PR title.

  • [ ] This PR title match the format: <type>(optional scope): <description>
  • [ ] The description of this PR title is user-oriented and clear enough for others to understand.
  • [ ] Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

xiaost avatar Apr 01 '25 07:04 xiaost

Codecov Report

:x: Patch coverage is 79.75543% with 149 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 79.20%. Comparing base (6e07744) to head (624e5c6). :warning: Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
...p/server/binding/internal/decoder/decoder_slice.go 61.95% 28 Missing and 7 partials :warning:
.../server/binding/internal/decoder/decoder_struct.go 67.70% 19 Missing and 12 partials :warning:
...pp/server/binding/internal/decoder/decoder_file.go 62.71% 16 Missing and 6 partials :warning:
...pp/server/binding/internal/decoder/decoder_base.go 87.82% 11 Missing and 3 partials :warning:
...ver/binding/internal/decoder/decoder_customfunc.go 66.66% 7 Missing and 4 partials :warning:
...app/server/binding/internal/decoder/decoder_map.go 55.00% 6 Missing and 3 partials :warning:
pkg/app/server/binding/internal/decoder/tag.go 78.57% 8 Missing and 1 partial :warning:
pkg/app/server/binding/internal/decoder/field.go 94.01% 5 Missing and 2 partials :warning:
pkg/app/server/binding/internal/decoder/decoder.go 72.72% 4 Missing and 2 partials :warning:
pkg/app/server/binding/internal/decoder/getter.go 90.32% 2 Missing and 1 partial :warning:
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1318      +/-   ##
===========================================
+ Coverage    74.11%   79.20%   +5.09%     
===========================================
  Files          145      145              
  Lines        16953    16560     -393     
===========================================
+ Hits         12564    13117     +553     
+ Misses        3796     2810     -986     
- Partials       593      633      +40     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 01 '25 10:04 codecov[bot]

是否有计划支持 go-playground/validator 的翻译器和自定义验证函数呢

FlameMida avatar Sep 04 '25 02:09 FlameMida