troposphere icon indicating copy to clipboard operation
troposphere copied to clipboard

Feature/support passing ref to user data

Open jaekunchoi opened this issue 7 years ago • 4 comments

Ref is now supported in the method from_file of helper file. Also added unit test Should address issue #724 @markpeek please review. I was able to successfully run userdata with Ref on AWS.

jaekunchoi avatar May 22 '17 14:05 jaekunchoi

Nice change. I have two questions:

  1. It seems this will always look for Ref. Perhaps it should be an option or another function name search for Ref.
  2. Right now it only looks for 1 Ref. Is there a use case to look for multiple Ref's?

markpeek avatar Jun 04 '17 19:06 markpeek

@markpeek thanks for the feedback. I've updated userdata script with multiple refs and asserting these results in the test. It passes with mutliple Refs being replaced. I've also added an option to include Ref.

Thanks again!

jaekunchoi avatar Jun 25 '17 13:06 jaekunchoi

@markpeek do you have any feedback on the changes?

jaekunchoi avatar Jul 27 '17 10:07 jaekunchoi

Plans to merge this?

ollikaven avatar Oct 22 '18 12:10 ollikaven