troposphere
troposphere copied to clipboard
Feature/controltower parameters value types
Fixes #2313
Thank you for the PR plus using the patch mechanism and adding tests. There is one more change needed to apply the patch into the troposphere directory. Here are the steps (note: you will likely need to pull the recent changes for spec 200.0.0 and rebase your changes):
# Download CloudFormationResourceSpecification.json
make spec
# Apply the patches
make regen
# Run git diff and you should only see 2 lines changed in troposphere/controltower.py due to the patch being applied
git diff troposphere
# Run tests and lint (may need to specify the exact correct pyright)
npm install [email protected]
make test
make lint
# however you want to commit it into your changes, perhaps by rebasing it
git add troposphere/controltower.py
git commit ...
Thank you!