cloudstate icon indicating copy to clipboard operation
cloudstate copied to clipboard

.NET Core support

Open viktorklang opened this issue 6 years ago • 10 comments
trafficstars

It would be really cool to support .NET Core for user functions!

viktorklang avatar Sep 11 '19 11:09 viktorklang

I've ported some of Lagom to NETcore in the past (nagytech/lagom-dotnet) so I'm keen to help with a NETcore implementation of CloudState.

But, I've run into a few minor issues so far. First, I've had to to dig into the NETCore gRpc implementation. The current Google.Protobuf library they use protects the reflective Descriptor classes. When I get to a point where it will build and I'm not embarrassed about the code, I'll check it in for some review.

ghost avatar Oct 04 '19 02:10 ghost

@nagytech Very cool, this will be very interesting! Let us know if you have any questions, the gitter channel is typically a good place to ask questions.

viktorklang avatar Oct 04 '19 07:10 viktorklang

I've added my implementation here: https://github.com/nagytech/cloudstate-csharp/

But, as mentioned earlier I still need to resolve the issues in the csharp libraries for Protobuf and gRPC. One of them will need to wait for Protobuf 3.11.0: https://github.com/protocolbuffers/protobuf/issues/5441

Additionally, there is an outstanding issue in VSCode that makes developing gRPC quite difficult:

In the meantime, I'm going to refine and document what I've created.

ghost avatar Oct 26 '19 02:10 ghost

@nagytech Cool, I'll have a look!

viktorklang avatar Oct 28 '19 14:10 viktorklang

I believe that this can be merged with an official repository on cloudstate github account. I did a review with Jonathan that resulted in this minor issue, but I believe that everything else is fit.

sleipnir avatar Feb 04 '20 12:02 sleipnir

The issue is not related to TCK testing features so it should not impact anyone using this library.

sleipnir avatar Feb 04 '20 12:02 sleipnir

The issue is not related to TCK testing features so it should not impact anyone using this library.

but I still sent a PR https://github.com/nagytech/cloudstate-csharp/pull/7

sleipnir avatar Feb 04 '20 14:02 sleipnir

@sleipnir @nagytech Created this: https://github.com/cloudstateio/dotnet-support prepare PR?

viktorklang avatar Feb 04 '20 14:02 viktorklang

Thanks @viktorklang. I'll send one through in the next day or so.

ghost avatar Feb 06 '20 01:02 ghost

Perfect, thanks @nagytech!

viktorklang avatar Feb 06 '20 15:02 viktorklang