cshark icon indicating copy to clipboard operation
cshark copied to clipboard

HTTP errors should be returned by cshark

Open thomasp11 opened this issue 4 years ago • 2 comments

If there is any issue during the upload where CloudShark returns a non 200 OK response the cshark plugin returns a generic message back to the client:

https://github.com/cloudshark/cshark/blob/c0d32fb6df3cd095fecac8aefe8d188170246403/src/uclient.c#L44-L51

static void cshark_header_done_cb(struct uclient *ucl)
{
	if (ucl->status_code != 200) {
		ERROR("%s: received error, please double check your config file\n", PROJECT_NAME);
		uclient_disconnect(ucl);
		uloop_end();
	}
}

This should also return the error code and message sent by the CloudShark server to the client.

thomasp11 avatar Nov 09 '21 15:11 thomasp11

Thanks Tom, for the quick reaction to my support request. Much appreciated.

zaphod-pab avatar Nov 09 '21 16:11 zaphod-pab

Thanks Tom, for the quick reaction to my support request. Much appreciated.

On the other hand, seeing this is a duplicate to issue #4 from 2015 my hopes are fading somewhat ;-)

zaphod-pab avatar Nov 09 '21 16:11 zaphod-pab