components icon indicating copy to clipboard operation
components copied to clipboard

Sample date-time picker implementation

Open pan-kot opened this issue 2 years ago • 1 comments

Description

Sample date-time picker that uses time utils from date range picker implementation.

How has this been tested?

[How did you test to verify your changes?]

[How can reviewers test these changes efficiently?]

[Check for unexpected visual regressions, see CONTRIBUTING.md for details.]

Documentation changes

[Do the changes include any API documentation changes?]

  • [ ] Yes, this change contains documentation changes.
  • [ ] No.

Related Links

[Attach any related links/pull request for this change]

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • [ ] Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • [ ] Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • [ ] Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • [ ] Changes are covered with new/existing unit tests?
  • [ ] Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

pan-kot avatar Aug 01 '22 09:08 pan-kot

Codecov Report

Merging #98 (c7b01d5) into main (a77eb6e) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files         533      533           
  Lines       15462    15463    +1     
  Branches     4256     4256           
=======================================
+ Hits        14280    14281    +1     
  Misses       1097     1097           
  Partials       85       85           
Impacted Files Coverage Δ
src/date-range-picker/time-offset.ts 100.00% <100.00%> (ø)
src/test-utils/dom/attribute-editor/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bf5671f...c7b01d5. Read the comment docs.

codecov-commenter avatar Aug 01 '22 09:08 codecov-commenter

Closed in favour of https://github.com/cloudscape-design/components/pull/166

pan-kot avatar Aug 18 '22 07:08 pan-kot