components
components copied to clipboard
fix: Fix top navigation text overflowing when provided with 100% w-h svgs
Description
https://github.com/cloudscape-design/components/issues/704
If there is a provided svg to the top navigation component logo that has 100%
for height and width in the svg definition the top navigation title will always overflow and be cut.
To reproduce this, edit one of the sample svg logos in the test pages and make it have 100% height and width and check the page.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
- Changes include appropriate documentation updates.
-
Changes are backward-compatible if not indicated, see
CONTRIBUTING.md
. -
Changes do not include unsupported browser features, see
CONTRIBUTING.md
. - Changes were manually tested for accessibility, see accessibility guidelines.
Security
-
If the code handles URLs: all URLs are validated through the
checkSafeUrl
function.
Testing
- Changes are covered with new/existing unit tests?
- Changes are covered with new/existing integration tests?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Codecov Report
Patch coverage has no change and project coverage change: +0.02
:tada:
Comparison is base (
fdcae9b
) 92.76% compared to head (407a650
) 92.79%.
Additional details and impacted files
@@ Coverage Diff @@
## main #826 +/- ##
==========================================
+ Coverage 92.76% 92.79% +0.02%
==========================================
Files 605 606 +1
Lines 15725 15890 +165
Branches 5069 5120 +51
==========================================
+ Hits 14588 14745 +157
- Misses 1059 1067 +8
Partials 78 78
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Is this PR still relevant after https://github.com/cloudscape-design/components/pull/1069 or should it be closed?