components icon indicating copy to clipboard operation
components copied to clipboard

fix(date-picker,date-range-picker): Focus outline radius

Open connorlanigan opened this issue 2 years ago • 0 comments

Description

This change updates the radius of the focus outline for the dropdown part of the Date Picker and the Date Range Picker. While the dropdown acts as a container, it has a different border-radius than the Container component. The radius for the focus outline did not match this different border-radius.

Before

Screenshot of the state before the fix

After

Screenshot of the state after the fix

How has this been tested?

How did you test to verify your changes?
Manual testing in the browser

How can reviewers test these changes efficiently?

  • Open http://localhost:8080/#/light/date-picker/simple
  • Focus the input field
  • Press Tab to move the focus to the button, and Enter to open the dropdown
  • Observe the focus radius around the dropdown

[Check for unexpected visual regressions, see CONTRIBUTING.md for details.]

Documentation changes

Do the changes include any API documentation changes?

  • [ ] Yes, this change contains documentation changes.
  • [X] No.

Related Links

n/a

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • [X] Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • [X] Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • [X] Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • [ ] Changes are covered with new/existing unit tests?
  • [ ] Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

connorlanigan avatar Jul 18 '22 14:07 connorlanigan