components icon indicating copy to clipboard operation
components copied to clipboard

[Feature Request]: Show TextFilter count text in inactive/disabled color when loading

Open phuctm97 opened this issue 1 year ago • 3 comments

Description

Collection filter components has countText and loading props to display the number of matched results:

  • countText always shows & triggers screen readers when there are filters
  • loading delays screen readers to announce countText until it's false because the current countText may be out of date. It would make a lot of sense and a great user experience to show the countText in inactive/disabled status to indicate that it's out of date. Alternative solution is to have more specific loading/stale indicator for countText, but I think simply showing it in inactive/disabled color is already a great solution.

Code of Conduct

phuctm97 avatar Dec 28 '24 10:12 phuctm97

Hi, thanks for reaching out. Adding a visual indicator of loading to the count text does seem like a sensible addition to the text filter component, however we don’t have any plans for making this change at the moment.

cansuaa avatar Jan 07 '25 10:01 cansuaa

Hi, thanks for reaching out. Adding a visual indicator of loading to the count text does seem like a sensible addition to the text filter component, however we don’t have any plans for making this change at the moment.

Would you guys accept a PR for this though? It seems to be a very simple PR and I'm willing to submit it.

phuctm97 avatar Jan 09 '25 14:01 phuctm97

Hi @phuctm97,

Thanks for your feedback on the collection filter. To help us better understand the issue and find the best solution, could you please provide a bit more context on the following:

  • Use case: Can you describe typical use cases where users would rely on the countText while filtering? How important is it that the count is always up-to-date, given it's pretty smooth and quick to be updated?
  • Impact of outdated count: What problems have you noticed when the countText is out of date during the loading phase?
  • Screen reader behavior: Sounds like your primary concerns may relate to screen reader experiences. If so, did you notice any issues with how the countText is announced while loading?

Best regards, Atsushi

at-susie avatar Jan 14 '25 11:01 at-susie