components icon indicating copy to clipboard operation
components copied to clipboard

Upgrade react-virtual and react-resizable dependencies

Open timogasda opened this issue 2 years ago • 1 comments

Description

Some of the current dependencies technically don't support React 18 as a peer dependencies. This change updates those to include React 18 support.

This should remove peer dependencies warnings when using Cloudscape components with npm v8, which is must stricter about peer dependencies than npm v6 and v7.

How has this been tested?

Tested locally so far. Also manually tested the Code editor's resize handler.

Will continue testing internally.

Documentation changes

[Do the changes include any API documentation changes?]

  • [ ] Yes, this change contains documentation changes.
  • [x] No.

Related Links

[Attach any related links/pull request for this change]

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • [ ] Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • [ ] Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • [ ] Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • [ ] Changes are covered with new/existing unit tests?
  • [ ] Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

timogasda avatar Sep 14 '22 11:09 timogasda

Codecov Report

Merging #271 (d7b6c18) into main (2fb8f00) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   92.67%   92.67%           
=======================================
  Files         559      559           
  Lines       15759    15759           
  Branches     4306     4306           
=======================================
  Hits        14604    14604           
  Misses       1074     1074           
  Partials       81       81           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 14 '22 11:09 codecov[bot]