components
components copied to clipboard
feat: Allow button dropdown items to have an external icon without requiring href
Description
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
- Changes include appropriate documentation updates.
- Changes are backward-compatible if not indicated, see
CONTRIBUTING.md. - Changes do not include unsupported browser features, see
CONTRIBUTING.md. - Changes were manually tested for accessibility, see accessibility guidelines.
Security
- If the code handles URLs: all URLs are validated through the
checkSafeUrlfunction.
Testing
- Changes are covered with new/existing unit tests?
- Changes are covered with new/existing integration tests?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.84%. Comparing base (
b922cf1) to head (c604be4). Report is 269 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2691 +/- ##
==========================================
- Coverage 95.84% 95.84% -0.01%
==========================================
Files 744 744
Lines 20581 20581
Branches 7015 7015
==========================================
- Hits 19726 19725 -1
- Misses 847 848 +1
Partials 8 8
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.