components icon indicating copy to clipboard operation
components copied to clipboard

fix: Remove unnecessary delay before enabling chart interactions

Open jperals opened this issue 6 months ago • 1 comments

Description

Setting isHandlersDisabled to true is only necessary at the moment where a popover is pinned. This is managed in the effect right below the change in this PR. It doesn't need to be set to true at first render. Doing so provokes a delay until the chart can be interacted with, which is non-perceivable to the end user but affects tests.

Related: https://github.com/cloudscape-design/components/discussions/2581

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jperals avatar Aug 22 '24 21:08 jperals