components icon indicating copy to clipboard operation
components copied to clipboard

test: Add visual regression coverage for borderless table inside container with paddings

Open jperals opened this issue 7 months ago • 1 comments

Description

Borderless table in Visual Refresh does not include its own internal paddings so the padding needs to be provided by the container, whereas in Classic the padding from the container needs to be removed.

We have visual regression test for a borderless table inside a container with disableContentPaddings={true}, which is how it is supposed to be used in Classic, but not inside a container with disableContentPaddings={false} (or without disableContentPaddings set), which is how it is supposed to be used in Visual Refresh.

How has this been tested?

Existing visual regression tests in the pipeline

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jperals avatar Jun 26 '24 13:06 jperals