components
components copied to clipboard
wip: Button tooltip for disabled reason and loading text (same color treatment)
Description
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
- Changes include appropriate documentation updates.
-
Changes are backward-compatible if not indicated, see
CONTRIBUTING.md
. -
Changes do not include unsupported browser features, see
CONTRIBUTING.md
. - Changes were manually tested for accessibility, see accessibility guidelines.
Security
-
If the code handles URLs: all URLs are validated through the
checkSafeUrl
function.
Testing
- Changes are covered with new/existing unit tests?
- Changes are covered with new/existing integration tests?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Codecov Report
Attention: Patch coverage is 80.00000%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 95.38%. Comparing base (
8f69458
) to head (3ef2cbf
). Report is 375 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/button/internal.tsx | 77.77% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #2256 +/- ##
==========================================
- Coverage 95.40% 95.38% -0.03%
==========================================
Files 704 705 +1
Lines 18714 18729 +15
Branches 5945 6276 +331
==========================================
+ Hits 17855 17864 +9
- Misses 852 858 +6
Partials 7 7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.