components
components copied to clipboard
feat: Table renderAriaLive receives visibleItemsCount
Description
Adding visibleItemsCount
argument to table's renderAriaLive
so that the table can announce the difference in visible items when an expandable group is expanded or collapsed. For example:
- Table renders -
displaying clusters 1 to 10 of 35, 10 resources visible
- User expands a group -
displaying clusters 1 to 10 of 35, 13 resources visible
- User loads more items for the group -
displaying clusters 1 to 10 of 35, 16 resources visible
- User changes filter -
displaying clusters 1 to 10 of 17, 12 resources visible
- User changes page -
displaying clusters 11 to 17 of 17, 7 resources visible
How has this been tested?
- Unit tests
- Dry-run
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
- Changes include appropriate documentation updates.
-
Changes are backward-compatible if not indicated, see
CONTRIBUTING.md
. -
Changes do not include unsupported browser features, see
CONTRIBUTING.md
. - Changes were manually tested for accessibility, see accessibility guidelines.
Security
-
If the code handles URLs: all URLs are validated through the
checkSafeUrl
function.
Testing
- Changes are covered with new/existing unit tests?
- Changes are covered with new/existing integration tests?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.34%. Comparing base (
33d970f
) to head (2c6ef98
).
Additional details and impacted files
@@ Coverage Diff @@
## main #2165 +/- ##
=======================================
Coverage 95.34% 95.34%
=======================================
Files 687 687
Lines 18377 18377
Branches 6138 6138
=======================================
Hits 17521 17521
Misses 802 802
Partials 54 54
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.