components icon indicating copy to clipboard operation
components copied to clipboard

fix: Allow touch devices to resize table columns

Open avinashbot opened this issue 1 year ago • 1 comments

Description

Does what it says on the tin. I checked it in Chrome's touch "emulation" mode, on Android, and iPhone (through BrowserStack). What actually scares me is whether downstream tests will break after this. But the dry-run seems to look good, so...

Related links, issue #, if available: n/a

How has this been tested?

Manually. Existing tests should continue to work... I'm really counting on them to.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

avinashbot avatar Apr 17 '24 00:04 avinashbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.29%. Comparing base (dfa46e9) to head (500975a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2164      +/-   ##
==========================================
- Coverage   95.50%   95.29%   -0.21%     
==========================================
  Files         708      708              
  Lines       18892    18892              
  Branches     6293     6333      +40     
==========================================
- Hits        18043    18004      -39     
- Misses        795      880      +85     
+ Partials       54        8      -46     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 17 '24 00:04 codecov[bot]