fix: Remove negative margin from Button inline link variant

[michaeldowseza]

Description

Removed negative margin for inline link variant. Expected visual difference in Button permutations.

Before:

After:

Related links, issue #, if available: n/a AWSUI-37538

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

• Changes include appropriate documentation updates.
• Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
• Changes do not include unsupported browser features, see CONTRIBUTING.md.
• Changes were manually tested for accessibility, see accessibility guidelines.

Security

• If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

• Changes are covered with new/existing unit tests?
• Changes are covered with new/existing integration tests?

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.39%. Comparing base (d24a84c) to head (95cf23f).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2081   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files         696      696           
  Lines       18646    18646           
  Branches     6191     6191           
=======================================
  Hits        17788    17788           
  Misses        804      804           
  Partials       54       54           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[timogasda]

Is "Icon margin escaping Button inline link variant container" the best description for the release notes? I would be more clear with what we're fixing.

[michaeldowseza]

Is "Icon margin escaping Button inline link variant container" the best description for the release notes? I would be more clear with what we're fixing.

Any suggestions? I thought this was exactly what this was fixing?

[johannes-weber]

Is "Icon margin escaping Button inline link variant container" the best description for the release notes? I would be more clear with what we're fixing.

Any suggestions? I thought this was exactly what this was fixing?

What about: "Realign icon margin for Button inline link variant"?

[timogasda]

(ugh, why can't I do top-level threads in GitHub?!)

I don't have any suggestion for the PR title, because I still don't really understand what we're trying to fix 😅