components icon indicating copy to clipboard operation
components copied to clipboard

chore: Adjust the inner arrow position for VR to align the stroke appearance

Open at-susie opened this issue 1 year ago • 1 comments

Description

The stroke of the arrow of Popover component in VR looks thinner and different from the stroke of Popover's rectangle part.

arrow-popover

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

at-susie avatar Jan 26 '24 08:01 at-susie

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6dfd839) 94.78% compared to head (c8355cc) 94.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1916   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files         662      662           
  Lines       17932    17935    +3     
  Branches     5923     5924    +1     
=======================================
+ Hits        16997    17000    +3     
  Misses        870      870           
  Partials       65       65           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 26 '24 09:01 codecov[bot]

Changes look good to me, but why aren't we having visual regressions https://d21d5uik3ws71m.cloudfront.net/components/c8355cc91252ab25408d946adfb5bc9314720268/visual-regressions/html_report/index.html?

rubencarvalho avatar Jan 31 '24 09:01 rubencarvalho