components
components copied to clipboard
feat: Top navigation custom identity
Description
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
- Changes include appropriate documentation updates.
-
Changes are backward-compatible if not indicated, see
CONTRIBUTING.md
. -
Changes do not include unsupported browser features, see
CONTRIBUTING.md
. - Changes were manually tested for accessibility, see accessibility guidelines.
Security
-
If the code handles URLs: all URLs are validated through the
checkSafeUrl
function.
Testing
- Changes are covered with new/existing unit tests?
- Changes are covered with new/existing integration tests?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Codecov Report
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
7c06c07
) 94.72% compared to head (26a031f
) 94.70%.
Files | Patch % | Lines |
---|---|---|
src/top-navigation/internal.tsx | 66.66% | 3 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1912 +/- ##
==========================================
- Coverage 94.72% 94.70% -0.03%
==========================================
Files 659 659
Lines 17929 17935 +6
Branches 5932 5937 +5
==========================================
+ Hits 16984 16986 +2
- Misses 880 883 +3
- Partials 65 66 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.