components
components copied to clipboard
feat: Table grid navigation
Description
The PR integrates grid navigation (enhanced keyboard navigation) feature into the table component and makes it available through a public API.
Related links:
- API: 5uPHAylzAuFG
- Tech design: KtAVARsTM7ko
- Draft guidelines: U6xBAYcsDaYu
- Bug bash: 8QVkA8fIBunR
- Previous PR: https://github.com/cloudscape-design/components/pull/1856
How has this been tested?
More integration tests to existing pages (inline editing, resizable columns, shift selection). Screenshot tests
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
- Changes include appropriate documentation updates.
-
Changes are backward-compatible if not indicated, see
CONTRIBUTING.md
. -
Changes do not include unsupported browser features, see
CONTRIBUTING.md
. - Changes were manually tested for accessibility, see accessibility guidelines.
Security
-
If the code handles URLs: all URLs are validated through the
checkSafeUrl
function.
Testing
- Changes are covered with new/existing unit tests?
- Changes are covered with new/existing integration tests?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Codecov Report
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
2af7864
) 94.79% compared to head (2e6e5ee
) 94.78%.
Files | Patch % | Lines |
---|---|---|
src/table/internal.tsx | 97.56% | 1 Missing :warning: |
src/table/table-role/utils.ts | 80.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1893 +/- ##
==========================================
- Coverage 94.79% 94.78% -0.02%
==========================================
Files 666 666
Lines 17972 17992 +20
Branches 5935 5942 +7
==========================================
+ Hits 17037 17054 +17
- Misses 870 873 +3
Partials 65 65
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.