components icon indicating copy to clipboard operation
components copied to clipboard

chore: Simplify DEFAULT_CHAR_REGEX for tag editor

Open avinashbot opened this issue 1 year ago • 1 comments

Description

https://caniuse.com/mdn-javascript_regular_expressions_unicode_character_class_escape

Screenshot 2024-01-15 at 13 15 55

How has this been tested?

Relying on existing tests and maybe a quick dry run, but maybe a couple more tests won't hurt.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

avinashbot avatar Jan 15 '24 12:01 avinashbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a086982) 94.75% compared to head (85cd305) 94.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1886      +/-   ##
==========================================
- Coverage   94.75%   94.75%   -0.01%     
==========================================
  Files         661      661              
  Lines       17989    17988       -1     
  Branches     5950     5950              
==========================================
- Hits        17045    17044       -1     
  Misses        879      879              
  Partials       65       65              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 15 '24 12:01 codecov[bot]