components icon indicating copy to clipboard operation
components copied to clipboard

fix: Use border radius design token for column headers in sticky header table

Open abdhalees opened this issue 1 year ago • 3 comments

Description

A more specific implementation of this reverted PR https://github.com/cloudscape-design/components/pull/1857

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

abdhalees avatar Jan 08 '24 09:01 abdhalees

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.36%. Comparing base (501edea) to head (4a5b497).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1867   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files         690      690           
  Lines       18419    18419           
  Branches     5829     5829           
=======================================
  Hits        17565    17565           
  Misses        847      847           
  Partials        7        7           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 08 '24 09:01 codecov[bot]

It would be nice to have more information on what this fixes from #1857. From the code it seems like it fixes the style of tables with header, but there is no new test that covers that case.

jperals avatar Jan 08 '24 14:01 jperals

It would be nice to have more information on what this fixes from #1857. From the code it seems like it fixes the style of tables with header, but there is no new test that covers that case.

@jperals applying border radius on full-page variant caused the column headers bottom border to be shortend. this PR applies the border radius only on container and stacked variant and only top border radius, these are the case where the issue happens.

this was caught by a screenshot test so there is already an exiting test that failed.

abdhalees avatar Jan 10 '24 10:01 abdhalees