components
components copied to clipboard
chore: Migrate "N/O/P/Q/R/S" components to logical properties
This PR is a subset of the changes drafted in https://github.com/cloudscape-design/components/pull/1713 that affect only the subset of components that being with the letters "N/O/P/Q/R/S".
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
ede4f46
) 94.78% compared to head (ef047b9
) 94.78%.
Additional details and impacted files
@@ Coverage Diff @@
## main #1793 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 662 662
Lines 17935 17935
Branches 5924 5924
=======================================
+ Hits 16999 17000 +1
+ Misses 871 870 -1
Partials 65 65
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The changes are generally looking good (left a couple of small comments), I tried to test a couple of dev pages to verify that the proper logical properties were applied but this is too big of a change to be verified only as a PR review.
I'm suggesting you can run some-sort of a quick bug-bash for each subset of components so people can make sure incorrect spacings or properties being used, I myself get confused a lot between [propertyName]-block
and [propertyName]-inline
, maybe can you also share how you did the change? was there some kind of script that read all the proerties and changed them or was it all manual?