components
components copied to clipboard
chore: Added missing FollowDetail to TopNavigationProps.Identity.onFo…
Description
The typing was incomplete for the TopNavigationProps.Identity.onFollow
, which caused my IDE to complain that the href
in the following is invalid:
<TopNavigation
identity={{
onFollow: (event) => {
event.preventDefault();
navigate(event.detail.href);
},
href: '/',
title: 'title',
logo: { src: logo, alt: 'ogo' }
}}
/>
Related links, issue #, if available: n/a
How has this been tested?
- Include this branch in your workspace.
- Copy the above code into your project
- The
href
now has a type.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
- Changes include appropriate documentation updates.
-
Changes are backward-compatible if not indicated, see
CONTRIBUTING.md
. -
Changes do not include unsupported browser features, see
CONTRIBUTING.md
. - Changes were manually tested for accessibility, see accessibility guidelines.
Security
-
If the code handles URLs: all URLs are validated through the
checkSafeUrl
function.
Testing
- Changes are covered with new/existing unit tests?
- Changes are covered with new/existing integration tests?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.