components icon indicating copy to clipboard operation
components copied to clipboard

chore: Added missing FollowDetail to TopNavigationProps.Identity.onFo…

Open IgniparousTempest opened this issue 1 year ago • 0 comments

Description

The typing was incomplete for the TopNavigationProps.Identity.onFollow, which caused my IDE to complain that the href in the following is invalid:

<TopNavigation
        identity={{
            onFollow: (event) => {
                event.preventDefault();
                navigate(event.detail.href);
            },
            href: '/',
            title: 'title',
            logo: { src: logo, alt: 'ogo' }
        }}
/>

Related links, issue #, if available: n/a

How has this been tested?

  1. Include this branch in your workspace.
  2. Copy the above code into your project
  3. The href now has a type.
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

IgniparousTempest avatar Dec 05 '23 22:12 IgniparousTempest