components icon indicating copy to clipboard operation
components copied to clipboard

Property filter with dates POC

Open pan-kot opened this issue 2 years ago • 1 comments

Description

Property filter with dates POC

How has this been tested?

New features:

  • Property filter can accept custom form per operator. The form is rendered instead of the default options list (unit test).
  • The extended operator form takes value, and onChange (unit test).
  • The extended operator form takes chosen operator and filter text (unit test).
  • Property filter can accept token value formatter per operator which renders the token value into the token (unit test).
  • Added date, datetime and boolean custom forms examples to test pages (screenshot tests).

[How did you test to verify your changes?]

[How can reviewers test these changes efficiently?]

[Check for unexpected visual regressions, see CONTRIBUTING.md for details.]

Documentation changes

[Do the changes include any API documentation changes?]

  • [ ] Yes, this change contains documentation changes.
  • [ ] No.

Related Links

[Attach any related links/pull request for this change]

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • [ ] Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • [ ] Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • [ ] Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • [ ] Changes are covered with new/existing unit tests?
  • [ ] Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

pan-kot avatar Aug 16 '22 13:08 pan-kot

Codecov Report

Base: 92.62% // Head: 92.65% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (71b938e) compared to base (48bf108). Patch coverage: 98.68% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   92.62%   92.65%   +0.02%     
==========================================
  Files         559      560       +1     
  Lines       15816    15894      +78     
  Branches     4328     4357      +29     
==========================================
+ Hits        14650    14726      +76     
- Misses       1084     1086       +2     
  Partials       82       82              
Impacted Files Coverage Δ
src/property-filter/controller.ts 99.32% <96.15%> (-0.68%) :arrow_down:
src/property-filter/index.tsx 95.96% <100.00%> (+0.47%) :arrow_up:
src/property-filter/property-editor.tsx 100.00% <100.00%> (ø)
...rc/property-filter/property-filter-autosuggest.tsx 91.17% <100.00%> (+2.84%) :arrow_up:
src/property-filter/token-editor.tsx 98.07% <100.00%> (+0.18%) :arrow_up:
src/property-filter/token.tsx 100.00% <100.00%> (ø)
src/split-panel/utils/use-pointer-events.ts 34.37% <0.00%> (-0.11%) :arrow_down:
src/app-layout/toggles/index.tsx 100.00% <0.00%> (ø)
src/app-layout/visual-refresh/tools.tsx 90.54% <0.00%> (ø)
src/app-layout/visual-refresh/app-bar.tsx 100.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 12 '22 07:09 codecov[bot]