components icon indicating copy to clipboard operation
components copied to clipboard

feat: Make more tables use role=grid by default

Open pan-kot opened this issue 1 year ago • 1 comments

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

pan-kot avatar Aug 28 '23 13:08 pan-kot

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fb4b027) 93.81% compared to head (68a4f80) 93.81%. Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1491   +/-   ##
=======================================
  Coverage   93.81%   93.81%           
=======================================
  Files         640      640           
  Lines       17273    17283   +10     
  Branches     5683     5686    +3     
=======================================
+ Hits        16204    16214   +10     
  Misses        996      996           
  Partials       73       73           
Files Changed Coverage Δ
src/table/header-cell/index.tsx 100.00% <100.00%> (ø)
src/table/internal.tsx 99.26% <100.00%> (+<0.01%) :arrow_up:
src/table/table-role/table-role-helper.ts 96.66% <100.00%> (+0.58%) :arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 28 '23 14:08 codecov[bot]