components icon indicating copy to clipboard operation
components copied to clipboard

refactor: Cell editing async store

Open pan-kot opened this issue 1 year ago • 1 comments

Description

A showcase for https://github.com/cloudscape-design/components/pull/1246.

Before change:

https://github.com/cloudscape-design/components/assets/20790937/0ff144cc-269c-40f9-b53e-ab71fd43030c

After change:

https://github.com/cloudscape-design/components/assets/20790937/e0c9c019-ec0f-4fdb-8f11-4034f442fe18

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

pan-kot avatar Aug 02 '23 15:08 pan-kot

Codecov Report

Patch coverage: 97.67% and project coverage change: -0.04% :warning:

Comparison is base (392b450) 93.55% compared to head (acee598) 93.51%. Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1402      +/-   ##
==========================================
- Coverage   93.55%   93.51%   -0.04%     
==========================================
  Files         627      627              
  Lines       16859    16858       -1     
  Branches     5568     5562       -6     
==========================================
- Hits        15772    15765       -7     
- Misses       1014     1020       +6     
  Partials       73       73              
Files Changed Coverage Δ
src/table/body-cell/td-element.tsx 91.30% <ø> (ø)
src/table/use-cell-editing.ts 95.45% <95.23%> (-4.55%) :arrow_down:
src/area-chart/async-store/index.ts 100.00% <100.00%> (ø)
src/table/body-cell/index.tsx 94.82% <100.00%> (-5.18%) :arrow_down:
src/table/internal.tsx 98.43% <100.00%> (-0.02%) :arrow_down:

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 02 '23 16:08 codecov[bot]