components icon indicating copy to clipboard operation
components copied to clipboard

Expose font size and weight as Themeable properties

Open sjakos opened this issue 1 year ago • 6 comments

Description

Font family is exposed as themeable, but font size is not. The font I'd like to use to be consistent with brand guidelines on a project I'm working on doesn't display well with the default of 14px, making the page less accessible. I'd like to be able to configure the fontSize properties when generating a themed build of Cloudscape to maintain accessibility guidelines with a brand consistent font.

Code of Conduct

sjakos avatar Jul 14 '23 14:07 sjakos

Hello Sam!

Allowing this does seem like a sensible addition to the system, however we don’t have any plans for making this change at the moment. We will keep this issue open to collect any additional feedback or use cases.

Thank you.

rubencarvalho avatar Jul 17 '23 13:07 rubencarvalho

This is a pretty crucial feature for being able to adopt this design system to match most designs.

bilalq avatar Aug 09 '23 01:08 bilalq

"Design system" means that there is already a predefined design. Theming was never intended to convert our design system to another design. It is only to make small visual adjustments

just-boris avatar Aug 09 '23 09:08 just-boris

That's fair. But I'd consider adjusting font sizes and weights to fall under the classification of "small visual adjustments".

bilalq avatar Aug 09 '23 12:08 bilalq

The ticket stays open, because the OP request is something we want to address. However "match most designs" is not a goal for our project.

just-boris avatar Aug 09 '23 13:08 just-boris

Apologies for my wording. By "most designs", I really only meant derivative designs of the underlying system. Things like tuning color palette, fonts, and border radiuses. Most of these are already supported.

bilalq avatar Aug 09 '23 15:08 bilalq

We have released themeable tokens for font sizes and font weights. You can find the list of tokens in the "Typography" tab of our token list on our website.

connorlanigan avatar Feb 29 '24 17:02 connorlanigan