components icon indicating copy to clipboard operation
components copied to clipboard

feat: Improve keyboard icon by making space bar narrower

Open whazor opened this issue 1 year ago • 1 comments

Description

The current keyboard icon is difficult to recognize, I propose making the space bar a bit narrower.

Current: current keyboard image Proposed: proposed keyboard image

Related links, issue #: n/a

How has this been tested?

Icon can be visually inspected.

Reviewers can add fill="#fff" stroke="#000000" to SVG options to check the image.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

whazor avatar May 03 '23 12:05 whazor

Hi @whazor! Thank you for providing the feedback and suggestion for the icon. Although we appreciate your suggestion for the keyboard icon, there doesn't seem to be significant difference. And we need data to prove that the icon that you've suggested works better than the current treatment. Do you have any user testing data to prove that?

at-susie avatar May 16 '23 15:05 at-susie

Closing this PR due to inactivity. Feel free to reopen with further information or to open an issue.

connorlanigan avatar Feb 29 '24 15:02 connorlanigan