components
components copied to clipboard
feat: Improve keyboard icon by making space bar narrower
Description
The current keyboard icon is difficult to recognize, I propose making the space bar a bit narrower.
Current:
Proposed:
Related links, issue #: n/a
How has this been tested?
Icon can be visually inspected.
Reviewers can add fill="#fff" stroke="#000000"
to SVG options to check the image.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
- Changes include appropriate documentation updates.
-
Changes are backward-compatible if not indicated, see
CONTRIBUTING.md
. -
Changes do not include unsupported browser features, see
CONTRIBUTING.md
. - Changes were manually tested for accessibility, see accessibility guidelines.
Security
-
If the code handles URLs: all URLs are validated through the
checkSafeUrl
function.
Testing
- Changes are covered with new/existing unit tests?
- Changes are covered with new/existing integration tests?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Hi @whazor! Thank you for providing the feedback and suggestion for the icon. Although we appreciate your suggestion for the keyboard icon, there doesn't seem to be significant difference. And we need data to prove that the icon that you've suggested works better than the current treatment. Do you have any user testing data to prove that?
Closing this PR due to inactivity. Feel free to reopen with further information or to open an issue.