Github provider removed anonymous access flag

Open jhosteny opened this issue 5 years ago • 1 comments

Found a bug? Maybe our Slack Community can help.

Describe the Bug

The Terraform Github provider was updated to remove the anonymous access flag. This was unfortunately done in a minor release. The current pessimistic constraint of ~> 2.2 fails, as the change appeared after 2.8.1 in 2.9.0.

See this change.

Expected Behavior

The module would continue to cleanly apply with the given constraint.

Steps to Reproduce

Steps to reproduce the behavior: An example can be seen in this PR.

Screenshots

N/A

Environment (please complete the following information):

Terraform version: 0.12.24 Github Provider version: 2.9.0

Additional Context

It can probably be fixed by setting the constraint to ~> 2.8.0 or >= 2.2, <2.9. Another potential fix is to adapt the module to use the newer provider, assuming there is equivalent functionality to the anonymous access now.

Upstream issue here, though I suspect that will result in just a clarification, and perhaps CHANGELOG change.

Jun 29 '20 20:06 jhosteny

For reference: https://github.com/terraform-providers/terraform-provider-github/issues/502#issuecomment-651627517

Jun 30 '20 12:06 jhosteny