terraform-aws-tfstate-backend icon indicating copy to clipboard operation
terraform-aws-tfstate-backend copied to clipboard

fix: improve `prevent_unencrypted_uploads` documentation

Open pazaan opened this issue 1 year ago • 9 comments

what

Update documentation for the prevent_unencrypted_uploads variable to more clearly explain its behavior.

why

references

  • Closes #177

notes

I also opened a PR on the CI job to fix this job error

pazaan avatar Jul 05 '24 06:07 pazaan

[!IMPORTANT]

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

mergify[bot] avatar Jul 05 '24 06:07 mergify[bot]

/terratest

gberenice avatar Jul 05 '24 07:07 gberenice

@cloudposse/engineering please review this PR.

gberenice avatar Jul 05 '24 09:07 gberenice

@pazaan thank you for the PR.

Please add description to this variable https://github.com/cloudposse/terraform-aws-tfstate-backend/blob/main/examples/complete/variables.tf#L1

The test is complaining that the description is missing https://github.com/cloudposse/terraform-aws-tfstate-backend/actions/runs/9992629334/job/27618115720?pr=179

aknysh avatar Jul 18 '24 13:07 aknysh

/terratest

gberenice avatar Jul 19 '24 11:07 gberenice

@pazaan could you please add one more change to examples/complete/variables.tf to satisfy tflint:

  variables.tf:6:1: warning: variable "arn_format" is declared but not used ()

gberenice avatar Jul 19 '24 11:07 gberenice

/terratest

gberenice avatar Jul 21 '24 11:07 gberenice

Thank you, @pazaan 👏

gberenice avatar Jul 21 '24 11:07 gberenice

@cloudposse/approvers please review this as a code owner.

gberenice avatar Jul 21 '24 11:07 gberenice