terraform-aws-tfstate-backend
terraform-aws-tfstate-backend copied to clipboard
cloudposse
Chore/118 fix deprecation warnings
what
Partially resolves deprecation warnings during terraform plan and terraform apply. Uses https://github.com/nozaq/terraform-aws-remote-state-s3-backend as a model. Remaining deprecation warnings should probably be corrected in a PR to in https://github.com/cloudposse/terraform-aws-s3-bucket (referenced in the log_storage module code used in this module).
why
- Avoid functionality loss when deprecated functions are dropped
- Reduce noise in
terraform planandterraform apply
references
- Closes https://github.com/cloudposse/terraform-aws-tfstate-backend/issues/118
HI @aknysh, thanks for the review. I've pushed changes that give me a terraform plan with no errors on Terraform 1.2.6.
~~The warnings that are blocking the terratest job are probably due to the s3-bucket module needing to be updated similarly. I'll submit a PR for that one and then notify here once that's resolved.~~
Never mind that...Not sure what's causing the context deadline exceeded errors here unfortunately. Any thoughts @aknysh ?
@joe-niland @RothAndrew any guidance on how I should address the context deadline exceeded error in terratest?
The terratest test passed this time, which means the failure was just AWS having a hiccup.
This looks like more than just a chore/refactor though, as it is making breaking changes to the inputs.
@aknysh, who's the right person to put this in front of to make sure this is a change we want to make? I don't have enough context on this module to give it the review it needs.
@matthewmrichter thanks for pinging me -- this had fallen off my radar. I should be able to devote some time to it in the coming week.