terraform-aws-ssm-tls-ssh-key-pair icon indicating copy to clipboard operation
terraform-aws-ssm-tls-ssh-key-pair copied to clipboard

Published 20 hours ago • verified publisher icon cloudposse

Removing deprecated overwrite option and associated docs and variable

Open bengaywins opened this issue 1 year ago • 6 comments

what

  • Remove the overwrite option on the SSM parameters

why

  • The overwrite option has been deprecated

references

  • https://github.com/hashicorp/terraform-provider-aws/issues/25636

bengaywins avatar Sep 25 '23 18:09 bengaywins

@max-lobur I know you weren't tagged in this, but you seem to be a recent committer and GH says you work for CloudPosse. Can this get reviewed? Or possible to get whatever is the right team member(s) to review it?

bengaywins avatar Oct 18 '23 21:10 bengaywins

/terratest

hans-d avatar Mar 02 '24 11:03 hans-d

💥 This pull request now has conflicts. Could you fix it @bengaywins? 🙏

mergify[bot] avatar Apr 09 '24 23:04 mergify[bot]

@hans-d I got the updates added to fix the CI checks! So ready for new testing whenever.

bengaywins avatar Apr 09 '24 23:04 bengaywins

Hi @bengaywins I discussed with other maintainers and we're going to hold on this one as the current situation with this deprecation does not appear to be finalised. Please see https://github.com/hashicorp/terraform-provider-aws/issues/25636#issuecomment-1623661159 for further info.

Probably once v6 of the AWS provider is released, we'll know how to proceed.

joe-niland avatar Apr 10 '24 10:04 joe-niland

Yeah I expected that @joe-niland! Thanks for the response.

bengaywins avatar Apr 10 '24 16:04 bengaywins