terraform-aws-s3-website icon indicating copy to clipboard operation
terraform-aws-s3-website copied to clipboard

Upgrade packages to support AWS v4

Open johncblandii opened this issue 2 years ago • 5 comments

what

  • Upgraded outdated packages and versions.tf

why

  • to support AWS v4 provider

references

  • Closes #75
  • Closes https://github.com/cloudposse/terraform-aws-s3-website/pull/62

johncblandii avatar Jul 01 '22 21:07 johncblandii

/test all

johncblandii avatar Jul 01 '22 21:07 johncblandii

/test all

johncblandii avatar Jul 01 '22 22:07 johncblandii

🤷🏽

TestExamplesComplete/Enabled 2022-07-01T22:36:49Z command.go:121: module.s3_website.module.logs.module.aws_s3_bucket.aws_s3_bucket.default[0]: Creating...
TestExamplesComplete/Disabled 2022-07-01T22:36:49Z command.go:121: ""
    examples_complete_test.go:109: 
        	Error Trace:	examples_complete_test.go:109
        	Error:      	Should be empty, but was ""
        	Test:       	TestExamplesComplete/Disabled

https://github.com/cloudposse/actions/runs/7157658521?check_suite_focus=true#step:9:679

johncblandii avatar Jul 01 '22 22:07 johncblandii

@johncblandii I believe this test fails because we're returning empty strings instead of null. I believe there was a discussion on it and we came to the conclusion that it's better to return an empty string.

The test probably needs to be updated because I think it's using an "exact search match" for the resource counts being zero.

https://github.com/cloudposse/terraform-aws-s3-website/blob/106b3e56bf7e071e70253c73bfdf58e646cb24b3/test/src/examples_complete_test.go#L108-L109

nitrocode avatar Jul 02 '22 00:07 nitrocode

@johncblandii I believe this test fails because we're returning empty strings instead of null. I believe there was a discussion on it and we came to the conclusion that it's better to return an empty string.

The test probably needs to be updated because I think it's using an "exact search match" for the resource counts being zero.

https://github.com/cloudposse/terraform-aws-s3-website/blob/106b3e56bf7e071e70253c73bfdf58e646cb24b3/test/src/examples_complete_test.go#L108-L109

Makes sense. I'll update it later.

johncblandii avatar Jul 02 '22 00:07 johncblandii

Any chance we could get this moving again? I can take a crack at updating that test assertion?

arichtman avatar Dec 16 '22 07:12 arichtman