terraform-aws-s3-bucket icon indicating copy to clipboard operation
terraform-aws-s3-bucket copied to clipboard

Minimal provider version for aws_s3_directory_bucket

Open salemgolemugoo opened this issue 1 year ago • 4 comments

what

Updated AWS provider version for the new resource used in the module aws_s3_directory_bucket

why

Old provider doesn't support this resource The provider hashicorp/aws does not support resource type

references

https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#5280-november-29-2023

salemgolemugoo avatar Dec 11 '24 12:12 salemgolemugoo

/terratest

nitrocode avatar May 06 '25 05:05 nitrocode

@Gowiem this would require a major version, right? If so, then we'd probably need to add all the non major changes first before this goes in

nitrocode avatar May 06 '25 05:05 nitrocode

@nitrocode I think we are treating major provider version bumps as major module version bumps, so that sounds right 👍

Gowiem avatar Jun 02 '25 20:06 Gowiem

Oh but @salemgolemugoo is saying that we're already using aws_s3_directory_bucket (which we are) and that resources REQUIRES v5.x of the AWS Provider... so we should've already did a major rev when we introduced that resource... damn.

@nitrocode I feel like it probably makes sense to raise this as a major rev and update all of the release docs from when that resource was added to mention that it should've included this provider rev to major. Mind taking that on?

Gowiem avatar Jun 02 '25 20:06 Gowiem