terraform-aws-rds icon indicating copy to clipboard operation
terraform-aws-rds copied to clipboard

Feat: Add Support for DB Instance Role Associations

Open korenyoni opened this issue 3 years ago • 16 comments

what

  • Add support for DB Instance Role Associations
  • Add BridgeCrew exceptions for errors stemming from this module parameterizing some resource attributes (false positives).
  • Expand Terratest tests.
  • Bump minimum supported Terraform version to 1.0.0 (see below).

why

  • Some RDS DB engines support different features depending on the engine. These should be supported by the module.
  • The comprehensive Terratest suite in examples/complete and test/src will only work with Terraform 1.0.0 and above, and otherwise will result in "count cannot be determined before apply" errors.

references

  • Closes #131

korenyoni avatar Dec 26 '21 16:12 korenyoni

/test all

korenyoni avatar Dec 26 '21 20:12 korenyoni

/test all

korenyoni avatar Dec 26 '21 20:12 korenyoni

/test all

korenyoni avatar Dec 26 '21 20:12 korenyoni

/test all

korenyoni avatar Dec 26 '21 21:12 korenyoni

/test all

korenyoni avatar Dec 26 '21 21:12 korenyoni

/test all

korenyoni avatar Dec 26 '21 22:12 korenyoni

/test all

korenyoni avatar Dec 26 '21 22:12 korenyoni

/test all

korenyoni avatar Dec 27 '21 11:12 korenyoni

/test all

korenyoni avatar Dec 27 '21 15:12 korenyoni

/test all

korenyoni avatar Dec 28 '21 15:12 korenyoni

/test all

korenyoni avatar Dec 28 '21 15:12 korenyoni

Bump! Is there anything blocking this PR from being merged, that we can help with?

adamantike avatar Apr 16 '22 22:04 adamantike

/test terratest

Gowiem avatar Apr 17 '22 17:04 Gowiem

/test test/terratest

Gowiem avatar Apr 17 '22 17:04 Gowiem

This pull request is now in conflict. Could you fix it @korenyoni? 🙏

mergify[bot] avatar Jun 17 '22 15:06 mergify[bot]

/test test/terratest

nitrocode avatar Jun 19 '22 13:06 nitrocode