terraform-aws-rds-cluster
terraform-aws-rds-cluster copied to clipboard
cloudposse
implement create_before_destroy on instances
what
I implemented create_before_destroy on the aws_rds_cluster_instance default instances.
why
Making a change to any parameter that triggers a replace on a aws_rds_cluster_instance results in all instances being destroyed before attempting to create a new instance which causes an outage. This a faster (and safer) altenative to #191
references
This closes #190 and is an alternative to #191
~Is there an upgrade path for this? The random_pet name will require cluster destroy if upgrading the module.~
Is there an upgrade path for this? The
random_petname will require cluster destroy if upgrading the module.
Hi @frimik this will not destroy the cluster, it will only replace the db instances.
@finchr hi, can you follow up on the reported check errors? thanks
Hi @hans-d sorry for the delay, I fixed the issue pushed the change.
TestExamplesServerlessV2PostgresDisabled 2024-03-08T17:32:33Z logger.go:66: ╷
TestExamplesServerlessV2PostgresDisabled 2024-03-08T17:32:33Z logger.go:66: │ Error: Provider produced inconsistent result after apply
TestExamplesServerlessV2PostgresDisabled 2024-03-08T17:32:33Z logger.go:66: │
TestExamplesServerlessV2PostgresDisabled 2024-03-08T17:32:33Z logger.go:66: │ When applying changes to
TestExamplesServerlessV2PostgresDisabled 2024-03-08T17:32:33Z logger.go:66: │ module.rds_cluster_aurora_serverlessv2_postgres_13.random_pet.instance,
TestExamplesServerlessV2PostgresDisabled 2024-03-08T17:32:33Z logger.go:66: │ provider "provider[\"registry.terraform.io/hashicorp/random\"]" produced an
TestExamplesServerlessV2PostgresDisabled 2024-03-08T17:32:33Z logger.go:66: │ unexpected new value: .prefix: was cty.StringVal(""), but now null.
TestExamplesServerlessV2PostgresDisabled 2024-03-08T17:32:33Z logger.go:66: │
TestExamplesServerlessV2PostgresDisabled 2024-03-08T17:32:33Z logger.go:66: │ This is a bug in the provider, which should be reported in the provider's
TestExamplesServerlessV2PostgresDisabled 2024-03-08T17:32:33Z logger.go:66: │ own issue tracker.
@hans-d @finchr I'm going to call in @Nuru on this one... this is one of those types of changes we want to be very thoughtful about and I'm sure Jeremy will have opinions.
Thanks @finchr for creating this pull request!
A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.
While you wait, make sure to review our contributor guidelines.
[!TIP]
Need help or want to ask for a PR review to be expedited?
Join us on Slack in the
#pr-reviewschannel.
![mergify[bot] avatar](https://avatars.githubusercontent.com/in/10562?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request now has conflicts. Could you fix it @finchr? 🙏
Conflicts resolved!
[!IMPORTANT]
Cloud Posse Engineering Team Review Required
This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.
To expedite this process, reach out to us on Slack in the
#pr-reviewschannel.
This PR was closed due to inactivity and merge conflicts. 😭 Please resolve the conflicts and reopen if necessary.
Seriously? You sit on this months and then request that I fix merge conflicts and close on the same day?
Sorry about that. I think we have an edge condition with the mergify rules that caused that to happen. Please click the button to reopen the PR and work with someone in #pr-reviews channel to get this merged.
Sorry about that. I think we have an edge condition with the mergify rules that caused that to happen. Please click the button to reopen the PR and work with someone in #pr-reviews channel to get this merged.
Hi @osterman I don't see a button or option to reopen the PR.